D8630: Created unit test for PlacesItemModel

Renato Oliveira Filho noreply at phabricator.kde.org
Thu Nov 23 14:31:28 GMT 2017


renatoo marked 2 inline comments as done.
renatoo added inline comments.

INLINE COMMENTS

> mwolff wrote in placesitemmodeltest.cpp:151
> ok, but we could still use `QTRY_COMPARE` then, no?

QTRY_COMPARE is not enough the model already has the correct size but the bookmark objects could be changed on the function executed while in idle.

In any case this is fixed on https://phabricator.kde.org/D8332

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8630

To: renatoo, ervin, elvisangelaccio, mwolff
Cc: mwolff, elvisangelaccio, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171123/e4020680/attachment.htm>


More information about the kfm-devel mailing list