D8822: Fix scrolling during inline renaming causes rename of wrong file

Andreas Krutzler noreply at phabricator.kde.org
Sat Nov 18 13:01:15 GMT 2017


akrutzler added inline comments.

INLINE COMMENTS

> rkflx wrote in kitemlistroleeditor.cpp:59
> Touchpad support was the first thing I looked up after Elvis mentioned this :). Apparently "Wheel events are generated for both mouse wheels and trackpad scroll gestures." Source <https://doc.qt.io/qt-5/qwheelevent.html>
> 
> As for testing touchscreen support, maybe there's some trickery you can setup in X11 to emulate touch events with a regular mouse?

In my former approach, the renaming was accepted once the View "scrolls" its content. It was completely independent of what the scrolling actually triggered since i was not catching any event. This could be either by mouse/touchpad or even programmatically by calling `KItemListView::scrollToItem` for example. IMO that should work for touchscreens too.

I tried to catch QEvent::Expose in `KItemListRoleEditor::eventFilter` and `KItemListRoleEditor::event` but i don't even get this event. :\

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8822

To: akrutzler, ngraham, rkflx, #dolphin, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171118/860860ee/attachment.htm>


More information about the kfm-devel mailing list