D8822: Fix scrolling during inline renaming causes rename of wrong file

Nathaniel Graham noreply at phabricator.kde.org
Fri Nov 17 18:44:38 GMT 2017


ngraham added inline comments.

INLINE COMMENTS

> kitemlistroleeditor.cpp:59
>  {
> -    if (watched == parentWidget() && event->type() == QEvent::Resize) {
> +    if (watched == parentWidget() && (event->type() == QEvent::Resize || event->type() == QEvent::Wheel)) {
>          emitRoleEditingFinished();

Not all users will be using a mouse with a wheel. Can we use `QEvent::Scroll` instead, so this continues to work with a laptop touchpad or touchscreen?

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D8822

REVISION DETAIL
  https://phabricator.kde.org/D8822

To: akrutzler, ngraham, rkflx, #dolphin
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171117/0d365cfe/attachment.htm>


More information about the kfm-devel mailing list