D8822: Rename inline: scrolling causes rename of wrong file

Henrik Fehlauer noreply at phabricator.kde.org
Thu Nov 16 06:30:11 GMT 2017


rkflx accepted this revision.
rkflx added a subscriber: elvisangelaccio.
rkflx added a comment.


  Had a look, works great, solves the bug and I cannot break it. Code seems fine. I still don't understand what is the actual problem in the bug, but at least it is not triggered anymore and the floating text input field is gone. Now shows same behaviour as in Windows Explorer, which is fine.
  
  @akrutzler Please add `Fixes T7443` to the summary :) Also, the title should not sound like a bug, instead reword to either describe the new behaviour, or add "Fix <the problem>".
  
  @elvisangelaccio Is this approvable from Dolphin's perspective?
  
  Note for the committer: This is currently branched from `master`, but should probably go to `Applications/17.12`.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8822

To: akrutzler, ngraham, rkflx, #dolphin
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171116/505dcc64/attachment.htm>


More information about the kfm-devel mailing list