D8822: Rename inline: scrolling causes rename of wrong file

[Henrik Fehlauer]

rkflx added a comment.


  Wow, can't wait to test this! (Busy currently, give me a day or two).

INLINE COMMENTS

> akrutzler wrote in kitemlistroleeditor.cpp:61
> Actually it's not necessary. Just my personal preference since `KIO::encodeFileName(toPlainText()` is used 3 times (2 in kitemlistroleeditor.cpp and 1 in kstandarditemlistwidget.cpp). But I can also remove this function.

In general I'd just follow the same style as the surrounding code. I don't think there is a rule specifying a point at which you are supposed to refactor into a function.

I'd probably just keep what you have done right now and wait whether Dolphin's maintainers like it or not (they should give the final green light anyway).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8822

To: akrutzler, ngraham, rkflx
Cc: #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171115/c6221de4/attachment.htm>