D8273: Change window title when searching

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:1005
> +    if (m_activeViewContainer->isSearchModeEnabled()) {
> +        const auto searchText = i18n("Search for %1", m_activeViewContainer->currentSearchText());
> +        setWindowTitle(searchText);

Please add a check if the search query is empty. Currently it will show "Search for " which doesn't look good.

REVISION DETAIL
  https://phabricator.kde.org/D8273

To: xyquadrat, #dolphin, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171112/f17b5778/attachment.htm>