D8273: Change window title when searching

Julian Schraner noreply at phabricator.kde.org
Sun Nov 12 19:15:44 GMT 2017


xyquadrat added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:1004
> Old patch was using `if (m_activeViewContainer->isSearchModeEnabled())`, why did you change it? (should be faster as it doesn't perform a substring match).

I thought your earlier comment implied that `isSearchModeEnabled()` will not work in some corner cases, but apparently I misunderstood that.

REVISION DETAIL
  https://phabricator.kde.org/D8273

To: xyquadrat, #dolphin, #kde_applications, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, markg, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171112/3a4b97f5/attachment.htm>


More information about the kfm-devel mailing list