D8273: Change window title when searching

Julian Schraner noreply at phabricator.kde.org
Sun Nov 12 19:14:13 GMT 2017


xyquadrat updated this revision to Diff 22235.
xyquadrat added a comment.


  Removed the `facetType()` and `currentFacet()` function as proposed by @elvisangelaccio. Merged the `search` and `text` variable into `searchText`, which now uses %1 to add in the current search text for better localization. But I am not entirely sure if the consent is that we remove the facets from the title (which gives more space) or if I should keep it (which gives more information to the user) but adapt to the other comments.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8273?vs=22233&id=22235

REVISION DETAIL
  https://phabricator.kde.org/D8273

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: xyquadrat, #dolphin, #kde_applications, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, markg, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171112/9314ee3f/attachment.htm>


More information about the kfm-devel mailing list