D8273: Change window title when searching

Julian Schraner noreply at phabricator.kde.org
Sun Nov 12 16:41:17 GMT 2017


xyquadrat updated this revision to Diff 22233.
xyquadrat added a comment.


  @elvisangelaccio The basic patch is the same, but the "Places" feature has been added & some code style changes were made.
  
  @anthonyfieroni I tried to adapt the code to your suggestions, any improvements from here?
  
  When the user selected a facet but hasn't entered any text the title is now "Search for [type] named". I can re-add the change so that it would be "Search for [type]" but this would inflate the patch size and IMO is about as good as it is now.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8273?vs=22221&id=22233

REVISION DETAIL
  https://phabricator.kde.org/D8273

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: xyquadrat, #dolphin, #kde_applications, ngraham
Cc: anthonyfieroni, elvisangelaccio, markg, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171112/5f281508/attachment.htm>


More information about the kfm-devel mailing list