D8722: Use new folder-stash icon

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> cfeck wrote in dolphinmainwindow.cpp:1099
> And thinking about it, fallbacks with QIcon::fromTheme() are probably useless, because our icon loader does automatic fallback according to XDG spec. In other words, if "folder-stash" is not available, it will load "folder". Even if this was not available, it would load a default "unknown" icon.
> 
> If you really want the fallback to a different icon to work, you probably need to use KIconLoader classes directly.

> And thinking about it, fallbacks with QIcon::fromTheme() are probably useless, because our icon loader does automatic fallback according to XDG spec. In other words, if "folder-stash" is not available, it will load "folder".

Oh, that's probably good enough then.
@ngraham can you restore the first version of this diff?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8722

To: ngraham, elvisangelaccio, #dolphin
Cc: cfeck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171110/4d749ca3/attachment.htm>