D8740: Prevent "Two clicks renaming" if the selected file/folder is not movable

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Just as a side node, this won't be needed once we'll have https://phabricator.kde.org/D7571, but for now we do need it indeed.
  
  In https://phabricator.kde.org/D8740#166130, @rkflx wrote:
  
  > - Apparently if you add `Fixes T7432`, the task you opened will get closed on commit. I'd be interested to know if that works…
  
  
  Sure, that works.

INLINE COMMENTS

> dolphinview.cpp:1128-1129
>      if (GeneralSettings::renameInline()) {
> -        m_twoClicksRenamingItemUrl = m_model->fileItem(index).url();
> -        m_twoClicksRenamingTimer->start(QApplication::doubleClickInterval());
> +        KFileItem item = m_model->fileItem(index);
> +        KFileItemListProperties capabilities(KFileItemList() << item);
> +        if (capabilities.supportsMoving()) {

Both can be `const`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8740

To: akrutzler, rkflx, #dolphin
Cc: elvisangelaccio, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171110/38e74bdb/attachment.htm>