D8740: Prevent "Two clicks renaming" if the selected file/folder is not movable

Henrik Fehlauer noreply at phabricator.kde.org
Thu Nov 9 20:28:07 GMT 2017


rkflx added a comment.


  Great, will have a look in the next days if no one beats me to it.
  
  Just some general remarks:
  
  - You've got some unrelated changes in this Diff, i.e. some older commits slipped in. Maybe you need to rebase? In general you can check with `arc which` how your `arc diff` will turn out. Just try again with `arc diff`, no need to open a new Diff.
  - Adding a dependent Diff is not really necessary if it is already committed. This is mainly to prevent you from landing changes with unmet deps, visualize the dep stack and help reviewers get all Diffs with a single `arc patch`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8740

To: akrutzler, rkflx, #dolphin
Cc: ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171109/784ec73b/attachment.htm>


More information about the kfm-devel mailing list