D7647: Two clicks on file/folder to rename

[Andreas Krutzler]

akrutzler added a comment.


  I was using this feature the last few days, and I encountered a small bug: there is no check if we have sufficient permission to rename something.
  Reproduce:
  
  - Go to a directory with no write permission (`/usr/` for example)
  - Two clicks to rename
  - -> inline renaming starts
  - -> rename
  - error message `Access denied to xxxx`.
  
  So we should only start two clicks renaming if we are allowed to.
  That's rather easy to fix, the only question for me is: should I open a new revision or reopen this one?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171108/f2b924a1/attachment.htm>