D8273: Change window title when searching
Julian Schraner
noreply at phabricator.kde.org
Tue Nov 7 20:22:28 GMT 2017
xyquadrat updated this revision to Diff 22051.
xyquadrat added a comment.
- Changed "Searching [user input]" to "Search for [user input]"
- Instead of using isSearchModeEnabled() I now use viewPropertyContext(), although I am not 100% sure if that will work with all corner cases (@emmanuelp probably knows that better)
I also tried to implement the suggestion to mention the type of search (e.g. for Documents). My problem is that the method to get the current facet (facetType()) is buried in dolphinfacetswidget.cpp, which I can't seem to access from dolphinmainwindow.cpp. Any ideas?
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8273?vs=20720&id=22051
REVISION DETAIL
https://phabricator.kde.org/D8273
AFFECTED FILES
src/dolphinmainwindow.cpp
src/dolphinviewcontainer.cpp
src/dolphinviewcontainer.h
To: xyquadrat, #dolphin, #kde_applications, ngraham
Cc: markg, rkflx, emmanuelp, ngraham, #dolphin, spoorun, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171107/01f9e475/attachment.htm>
More information about the kfm-devel
mailing list