D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

Elvis Angelaccio noreply at phabricator.kde.org
Tue Nov 7 16:12:15 GMT 2017


elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  Looks good to me now.
  
  In https://phabricator.kde.org/D6281#165049, @emateli wrote:
  
  > constBegin/End instead of .begin/end.
  >
  > Also, so we need some test cases for `urlListMatchesUrl`?
  
  
  Tests are always good :)

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
Cc: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171107/4b44d6b2/attachment.htm>


More information about the kfm-devel mailing list