D7440: Turn on Dolphin icon previews by default
Mark Gaiser
noreply at phabricator.kde.org
Mon Nov 6 16:57:45 GMT 2017
markg added a comment.
In https://phabricator.kde.org/D7440#165020, @ngraham wrote:
> That was my thought too, but @markg and @anthonyfieroni weren't too keen on all the duplicated code, and it does allow us to centralize the kconfig part rather than duplicating it three times.
I like the global one much more then your earlier attempt.
Also, the global one can go entirely once you can depend on the appropriate framework so it's temp anyhow.
As said before, I still have my doubts about this whole feature but don't want to be the one blocking it. Thus no +1 or -1 from me, it's just up to others to decide.
Code wise, it's a +1 though.
REPOSITORY
R318 Dolphin
BRANCH
arcpatch-D7440
REVISION DETAIL
https://phabricator.kde.org/D7440
To: ngraham, #dolphin, #kde_applications, #vdg, markg, abetts
Cc: abetts, cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror, spoorun, navarromorales, firef, ngraham, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171106/ef401456/attachment.htm>
More information about the kfm-devel
mailing list