D8454: Make Saved Search feature discoverable

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphincontextmenu.cpp:377
> Don't we need the FIXME comment also here?

We actually don't since we're no longer using `KIO::iconNameForUrl()` to get the icon for saved searches. Instead, as @anthonyfieroni suggested, we always hardcode the "folder-saved-search-symbolic" icon for saved searches, because even if `KIO::iconNameForUrl()` were fixed, it would still return a different icon (probably "file-search-symbolic") which may be inappropriate in certain icon themes.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8454

To: ngraham, #dolphin, #kde_applications, broulik, dfaure, markg, emateli, elvisangelaccio
Cc: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171101/8f702f8a/attachment.htm>