D5864: Correct specified transitions between searchbox, url navigator, tabs and split views
Elvis Angelaccio
noreply at phabricator.kde.org
Sat May 20 13:40:59 BST 2017
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
There is still a small regression, unfortunately:
1. Open split view
2. Open search box in both views
3. Click the search box of the inactive view
4. Palette of the inactive view doesn't change
INLINE COMMENTS
> dolphinviewcontainer.cpp:609-614
> + if (m_searchBox->isVisible()) {
> + m_searchBox->setFocus();
> + } else {
> + m_view->setFocus();
> + m_urlNavigator->setActive(true);
> + }
Why this change of behavior? If I click the file view I don't expect to get focus in the search box.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D5864
To: anthonyfieroni, elvisangelaccio, emmanuelp, sandsmark
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170520/822c73ff/attachment.htm>
More information about the kfm-devel
mailing list