D5919: Fix crash when closing tabs with search box open

Elvis Angelaccio noreply at phabricator.kde.org
Fri May 19 19:15:43 BST 2017


elvisangelaccio added a comment.


  In https://phabricator.kde.org/D5919#110836, @elvisangelaccio wrote:
  
  > Bah, I give up. Can't figure out a clean way to fix it.
  >  At this point I think we can go with @anthonyfieroni's initial fix (i.e. just check if `tabPage` is valid in `DolphinMainWindow::updateSplitAction()`).
  
  
  Even though it's conceptually wrong that `DolphinTabWidget::currentTabPage()` returns a nullptr. The other fix I can think of is disconneting the `activeViewChanged` signal before removing a tab.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D5919

To: elvisangelaccio, anthonyfieroni, emmanuelp
Cc: #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170519/8b725c88/attachment.htm>


More information about the kfm-devel mailing list