D5864: Correct specified transitions between searchbox, url navigator, tabs and split views

Anthony Fieroni noreply at phabricator.kde.org
Fri May 19 09:03:17 BST 2017


anthonyfieroni updated this revision to Diff 14684.
anthonyfieroni retitled this revision from "Do not update split actions when they or the tab page not present" to "Correct specified transitions between searchbox, url navigator, tabs and split views".
anthonyfieroni edited the test plan for this revision.
anthonyfieroni added a comment.


  Complete removal of activate, this slot and connections to it, like KUrlNavigator or SearchBox is unwanted and makes infinite loop to view (true / false) cause when url is changed KUrlNavigator fire activate then viewchanged is fired in there view->setActive is called to false, now we enter an infinite loop.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5864?vs=14623&id=14684

REVISION DETAIL
  https://phabricator.kde.org/D5864

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: anthonyfieroni, elvisangelaccio, emmanuelp, sandsmark
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170519/4e9513e5/attachment.htm>


More information about the kfm-devel mailing list