D5864: Do not update split actions when they or the tab page not present

[Anthony Fieroni]

anthonyfieroni updated this revision to Diff 14623.
anthonyfieroni edited the summary of this revision.
anthonyfieroni edited the test plan for this revision.
anthonyfieroni added a comment.


  Elvis, you are right. I revert https://phabricator.kde.org/R318:6af0dad2eeba82929c2299f66ea81e5d0140a251, it's doing in other way. Calling viewContainer->setActive(false), whenever it's called after close tab (because close tab activate DolphinTabWidget::currentTabChanged, causing recursive stack smash or reading the removed index (stack trace).
  I simplified the logic by removing DolphinViewContainer::activate, the problem is on closed tab KUrlNavigator or DolphinSearchBox reactivate the view (cause it's connected through DolphinViewContainer::activate). I don't see any reason KUrlNavigator, DolphinSearchBox and DolphinView to reactive itselfs.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5864?vs=14536&id=14623

REVISION DETAIL
  https://phabricator.kde.org/D5864

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: anthonyfieroni, elvisangelaccio, emmanuelp
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170517/a380cc91/attachment.htm>