Review Request 130028: Add a dedicated 'Copy To Stash' context menu button for the upcoming stash:/ ioslave

[arnav dhamija]

> On March 18, 2017, 11:18 p.m., Boudhayan Gupta wrote:
> > Could you also post a couple of screenshots detailing the UI changes?
> 
> arnav dhamija wrote:
>     Yes, I have posted an instance of the context menu with the copy to stash action.
> 
> Boudhayan Gupta wrote:
>     What about just "Stash" instead of "Copy to Stash"? I'd change the order of the actions too, so that Stash came above Move to Trash.
> 
> Mark Gaiser wrote:
>     Just chiming in.
>     
>     Be careful where you place an entry containing the name "stash" because it reads a lot like "trash" (no pun intended, I like the stach idea!)
>     I personally would place at least one completely differently named action between stash and trash. Just to avoid accidental "I wanted to put it on the stash, but misclicked and now it's in the trash" cases. The downside is that it looks rather odd (due to it not being sorted by alphabet anymore).
>     
>     So i suppose:
>     ---------------
>     Copy to stash
>     Rename
>     Move to trash
>     ---------------
>     
>     Also, regarding the "copy" in that line (Copy to stash). Isn't that a bit misleading? I thought the stash contained meta data about a file, but not a copy of it, right? If that's still the case then something like "Add to stash" might be better fitting, though still not ideal. I admit that picking a proper name for this is tricky!
> 
> Boudhayan Gupta wrote:
>     That's one of the reasons I'm being a little nitpicky about this: it's not actually a copy, it's just storing a reference.

> What about just "Stash" instead of "Copy to Stash"? I'd change the order of the actions too, so that Stash came above Move to Trash.

I chose not to keep it as just "Stash" as I already created a button named "Stash", pressing on which reveals the stash:/ ioslave in Dolphin's split view (RR 129044). The order was something I was hesitant to change as I felt it would disrupt user's muscle memory of where the "Move to Trash" button is.

> I personally would place at least one completely differently named action between stash and trash. Just to avoid accidental "I wanted to put it on the stash, but misclicked and now it's in the trash" cases. The downside is that it looks rather odd (due to it not being sorted by alphabet anymore).

Yes! Your order makes sense and I will change it with my next patch. 

> Also, regarding the "copy" in that line (Copy to stash). Isn't that a bit misleading? I thought the stash contained meta data about a file, but not a copy of it, right? If that's still the case then something like "Add to stash" might be better fitting, though still not ideal. I admit that picking a proper name for this is tricky!

Agreed. I'll change this as well.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130028/#review102899
-----------------------------------------------------------


On March 19, 2017, 9:50 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130028/
> -----------------------------------------------------------
> 
> (Updated March 19, 2017, 9:50 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch adds a dedicated Copy to Stash button in Dolphin's context menu when items are selected in a group. Triggering this action adds the selected items to the clipboard and pastes it on the stash:/ ioslave.
> 
> I have encountered some problems when writing this patch. For one, though the QAction appears in the context menu as expected, it does not show up in the Menubar's File Menu though it is added under that in the dolphinui.rc file. Apart from this, the patch works fine in manual testing.
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.cpp 890494f 
>   src/dolphinmainwindow.h d741eb2 
>   src/dolphinmainwindow.cpp de8601d 
>   src/dolphinpart.rc 725320b 
>   src/dolphinui.rc c446656 
>   src/views/dolphinview.h 5e69fd3 
>   src/views/dolphinview.cpp 63f6252 
> 
> Diff: https://git.reviewboard.kde.org/r/130028/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Context menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/03/19/085a8a51-86a7-4647-b5ae-fc8f0f599026__Screenshot_20170319_095338.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170319/ebab712a/attachment.htm>