Review Request 130028: Add a dedicated 'Copy To Stash' context menu button for the upcoming stash:/ ioslave

Boudhayan Gupta bgupta at kde.org
Sat Mar 18 23:18:24 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130028/#review102899
-----------------------------------------------------------



Could you also post a couple of screenshots detailing the UI changes?

- Boudhayan Gupta


On March 19, 2017, 2:16 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130028/
> -----------------------------------------------------------
> 
> (Updated March 19, 2017, 2:16 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch adds a dedicated Copy to Stash button in Dolphin's context menu when items are selected in a group. Triggering this action adds the selected items to the clipboard and pastes it on the stash:/ ioslave.
> 
> I have encountered some problems when writing this patch. For one, though the QAction appears in the context menu as expected, it does not show up in the Menubar's File Menu though it is added under that in the dolphinui.rc file. Apart from this, the patch works fine in manual testing.
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.cpp 890494f 
>   src/dolphinmainwindow.h d741eb2 
>   src/dolphinmainwindow.cpp de8601d 
>   src/dolphinpart.rc 725320b 
>   src/dolphinui.rc c446656 
>   src/views/dolphinview.h 5e69fd3 
>   src/views/dolphinview.cpp 63f6252 
> 
> Diff: https://git.reviewboard.kde.org/r/130028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170318/06e31ba6/attachment.htm>


More information about the kfm-devel mailing list