Review Request 128715: Bug 205157 - two clicks on file to rename

[Kåre Särs]

> On Sept. 4, 2016, 12:18 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > I don't think that we should add another option for this, because it makes the settings dialog
> > more complex, it increases the number of possible configs to test, it only makes sense when
> > single click + inline renaming is enabled.
> > 
> > What if we always enable it when the options 'single click' and 'inline renaming' are enabled?
> > 
> > Please add the usability group to this discussion :)
> 
> Thomas Pfeiffer wrote:
>     Usability team agrees :)
>     No additional option, activate it automatically when single-click and inline-renaming are activated
> 
> funky bomber wrote:
>     Hello,
>     
>     This feature doesn't seem to have been implemented yet (as of Applications 16.12), so I thought I might give my 2c as well. 
>     
>     
>     I have a hard time understanding how this feature is supposed to work if (as you say) it should require "single-click" to be activated. Why is that so?
>     In my understanding, an active "Single-click" means that when the user clicks once on a file, this file opens or executes immediately. This is not what we want.
>     
>     The "two clicks to rename" functionality makes sense only when the "Double-click" option is activated:
>     1) One click on the file (or folder) to highlight it.
>     2) (Brief pause)  <-- (The user can already set the "Double click interval" to whichever value suits them so that we don't trigger the double-click by accident.)
>     3) Second click on the file (or folder) to make the text editable.
>     
>     Pretty much the same as in this video:
>     https://www.youtube.com/watch?v=52BSGNY9DQ0
>     
>     
>     In regards to the complexity thing, I understand that each option that is added creates complexity. 
>     However it is the best way to isolate this behavior from users who may not want it. No size fits all.
>     And I think that this functionality is kind of a big deal. It deserves it's own setting. If not for anything else, 
>     then just so that people can find it and disable it easily if they don't want it.
>     
>     Hope to see this properly implemented in Applications 17.04!
>     
>     Cheers!
> 
> Anthony Fieroni wrote:
>     It should implement pretty simple, when user click over a selected item (it can be select more than one) rename is activated. Simple and useful, but yes only in double click branch

Having this in the "double-click" mode breaks the "Items are only selected with a single-click". It would have to be some kind of slower double click to not introduce a bunch of unwanted file renames. I find the in-line-rename found in Windows totally annoying. Selecting a file that happened to be selected already starts rename. What is wrong with explicitly pressing F2 or right-clicking the file?

And I have a bit hard time to understand how it could work in single-click mode when the file should be opened not renamed on single-click.


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128715/#review98869
-----------------------------------------------------------


On Sept. 5, 2016, 10:29 p.m., Andreas Krutzler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128715/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2016, 10:29 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Bug 205157 - two clicks on file to rename
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/kitemviews/kitemlistview.h 9adf9f8 
>   src/kitemviews/kitemlistview.cpp df65399 
>   src/views/dolphinview.h 0b0d819 
>   src/views/dolphinview.cpp 4105628 
> 
> Diff: https://git.reviewboard.kde.org/r/128715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Krutzler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170314/b620c003/attachment.htm>