D6379: FIX for https://bugs.kde.org/show_bug.cgi?id=362474

[Christoph Feck]

cfeck added a reviewer: Dolphin.
cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fileoperations.cpp:42
>  #include <lib/thumbnailprovider/thumbnailprovider.h>
> -
> +#include <lib/thumbnailprovider/thumbnailprovider.h>
> +#include <lib/contextmanager.h>

Not sure if the Diff is messed up, but here it looks like you are duplicating the include.

> fileoperations.cpp:43
> +#include <lib/thumbnailprovider/thumbnailprovider.h>
> +#include <lib/contextmanager.h>
>  namespace Gwenview

Please add empty line after include section.

> fileoperations.cpp:54
>  
> -    QFileDialog dialog(parent, QString(), "kfiledialog:///<copyMoveOrLink>");
> +  
> +    

Please only use single empty lines.

> contextmanager.cpp:294
> +
> +
>  void ContextManager::slotRowsInserted()

Double empty line here, too.

> contextmanager.h:75
> +    QUrl targetUrl() const;
> +
> +    void setTargetUrl(const QUrl&);

Remove unneeded empty line between related methods.

REPOSITORY
  R260 Gwenview

REVISION DETAIL
  https://phabricator.kde.org/D6379

To: sthiel, #dolphin, cfeck
Cc: cfeck, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170626/dee0bc84/attachment.htm>