Review Request 130157: Bug 321575 - Change window title when searching

[XY Quadrat]

> On Juni 26, 2017, 1:38 nachm., Elvis Angelaccio wrote:
> > Please update the commit message, it's no longer true that "... moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public".
> > 
> > Also, add "BUG: 321575" so that the bug report will be automatically closed after pushing the commit.

Updated commit message. Do I need to simply put BUG 321575 somewhere in the description or as the title?


- XY


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103369
-----------------------------------------------------------


On Juni 22, 2017, 4:57 nachm., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated Juni 22, 2017, 4:57 nachm.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
>   src/dolphinviewcontainer.cpp 72ced93 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170626/4c1b9494/attachment.htm>