D6312: Keep renamed file(s) in view

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dolphinview.cpp:1754
> +
> +void DolphinView::slotRenameDialogFinished(const QList<QUrl>& urls)
> +{

is this called even if the renaming is canceled?

> dolphinview.cpp:1766
> +}
> \ No newline at end of file


you should add a newline after '}'  (most editors do that automatically)

> dolphinview.h:771
> +     */
> +    void urlsForceSelection(const QUrl &current, const QList<QUrl> selected);
> +

missing "&" after const QList<QUrl>  (no need to copy)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6312

To: emateli, #dolphin
Cc: dfaure, #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170622/c1d3d24c/attachment.htm>