D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D6281#117864, @emateli wrote:
  
  > In https://phabricator.kde.org/D6281#117804, @elvisangelaccio wrote:
  >
  > > +1, great feature :)
  > >
  > > Please also add "BUG: 307747" in the commit message.
  > >  And yes, unused code is bad, please drop the getters if they are not used.
  >
  >
  > I don't have commit rights. Unless there's a way to specify the message here which I haven't found.
  
  
  The Summary of the review is usually used as commit message, when pushing someone else's code. Just add it there :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin
Cc: elvisangelaccio, dfaure, anthonyfieroni, #konqueror, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170621/eb2f40ef/attachment.htm>