D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1, great feature :)
  
  Please also add "BUG: 307747" in the commit message.
  And yes, unused code is bad, please drop the getters if they are not used.

INLINE COMMENTS

> kitemlistcontroller.cpp:1179
>  
> +    this->view()->setDragSource(data->urls());
> +

No need to use `this`.

> kitemlistview.cpp:47
>  #include <algorithm>
> +#include <kfileitem.h>
>  

Prefer `<KFileItem>`, see https://community.kde.org/Policies/Kdelibs_Coding_Style

> draganddrophelper.cpp:50
> +
> +            return NULL;
> +        }

nullptr

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin
Cc: elvisangelaccio, dfaure, anthonyfieroni, #konqueror, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170620/c762ca82/attachment.htm>