D6280: Dolphin softer drop shadow for thumbnails

Anthony Fieroni noreply at phabricator.kde.org
Mon Jun 19 20:27:08 BST 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> kpixmapmodifier.cpp:274
>              QImage image(8 * 3, 8 * 3, QImage::Format_ARGB32_Premultiplied);
> +            QColor color = QColor(0x61, 0x61, 0x61);
>  

Don't use hardcoded values, it can be difficult to maintain in the future. Use Qt::lightGray or other softer predefined vaules.

REVISION DETAIL
  https://phabricator.kde.org/D6280

To: emateli, #dolphin, #vdg
Cc: anthonyfieroni, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170619/cbe25822/attachment.htm>


More information about the kfm-devel mailing list