D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Emirald Mateli]

emateli created this revision.
emateli created this object with visibility "All Users".
emateli added a project: Dolphin.
Restricted Application added a subscriber: Konqueror.

REVISION SUMMARY
  This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
  
  The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
  
  I, myself see the message occasionally when working with the laptop touchpad. Due to their nature, sometimes you perform drag-and-drop unwillingly.
  Overall I think this is a positive change and also that I might need a better touchpad.
  
  Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
  F3787651: IMG_20170619_201229.jpg <https://phabricator.kde.org/F3787651>

TEST PLAN
  1. Drag a folder.
  2. Drop it onto itself.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6281

AFFECTED FILES
  src/kitemviews/kitemlistcontroller.cpp
  src/kitemviews/kitemlistview.cpp
  src/kitemviews/kitemlistview.h
  src/views/dolphinview.cpp
  src/views/draganddrophelper.cpp

To: emateli, #dolphin
Cc: #konqueror, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170619/ba92fb03/attachment.htm>