Review Request 130157: Bug 321575 - Change window title when searching

Elvis Angelaccio elvis.angelaccio at kde.org
Wed Jun 14 21:58:13 BST 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103322
-----------------------------------------------------------



+1, looks good to me now.

- Elvis Angelaccio


On June 14, 2017, 7:20 p.m., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 7:20 p.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
>   src/dolphinviewcontainer.cpp 72ced93 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170614/d3e0c38c/attachment.htm>


More information about the kfm-devel mailing list