Review Request 130157: Bug 321575 - Change window title when searching

[Christoph Feck]

> On June 13, 2017, 9:08 p.m., Christoph Feck wrote:
> > src/dolphinmainwindow.cpp, line 981
> > <https://git.reviewboard.kde.org/r/130157/diff/1/?file=496258#file496258line981>
> >
> >     Use ki18n() with arguments instead of concatenation.
> 
> XY Quadrat wrote:
>     So I looked up the ki18n() docs and managed to get everything running & working when I use i18n("Searching %1", ...) but when I try to use ki18n() instead the compiler gives an error ("too many arguments"). Is there a reason I should use ki18n() over i18n() (apart from that it gets initialized before the QApplication instance)? And if yes, how can I get it working?

Sorry my bad. It used to be called 'ki18n' in KDE4 times, now it is just 'i18n'.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------


On June 14, 2017, 9:20 p.m., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:20 p.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
>   src/dolphinviewcontainer.cpp 72ced93 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170614/30411192/attachment.htm>