Review Request 130157: Bug 321575 - Change window title when searching

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130157/#review103317
-----------------------------------------------------------




src/dolphinmainwindow.h 
<https://git.reviewboard.kde.org/r/130157/#comment68734>

    Unrelated whitespace change?



src/dolphinmainwindow.cpp (line 980)
<https://git.reviewboard.kde.org/r/130157/#comment68732>

    - add space after 'if'
    - add space before '{'



src/dolphinmainwindow.cpp (line 981)
<https://git.reviewboard.kde.org/r/130157/#comment68733>

    Use ki18n() with arguments instead of concatenation.



src/dolphinviewcontainer.h (line 96)
<https://git.reviewboard.kde.org/r/130157/#comment68735>

    This is bad. If code outside of the class needs to access the m_searchBox member, we don't just make it public, but add proper access methods.
    
    In this case, only getting the current search string is needed, so add a method something like currentSearchText().


- Christoph Feck


On June 13, 2017, 6:04 p.m., XY Quadrat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130157/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 6:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 321575
>     https://bugs.kde.org/show_bug.cgi?id=321575
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h d741eb2 
>   src/dolphinmainwindow.cpp 8d58043 
>   src/dolphinviewcontainer.h e50386a 
> 
> Diff: https://git.reviewboard.kde.org/r/130157/diff/
> 
> 
> Testing
> -------
> 
> - Disables it iself after search bar is hidden
> - Works with multiple word searches
> 
> 
> Thanks,
> 
> XY Quadrat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170613/27b6af5a/attachment.htm>