latest changes to downloads in konqueror

[Stefano Crocco]

Hello to everyone,
I hope this is still the right list to discuss issues about konqueror 
development. If not, could anybody tell me which is the correct place?

I saw one of the last commits to the konqueror repository (commit 
86ed60240e9eeb4bef08fa5fbdef04206ba2f04c) which attempts to fix the fact that, 
using the webengine part, konqueror always downloads files to the ~/Downloads 
directory (or to whichever directory the user has marked as default download 
directory). With this commit, konqueror always asks the user where to save the 
file. However, in my opinion, this severely cripples konqueror, removing one 
of its most useful features, the ability to show a downloaded file directly, 
without having the user explicitly save it.

In the last week, I have been working on this issue and reached a point which 
is (again, in my opinion), more satisfying as it mostly restores the previous 
behaviour. I attach a diff against the current master showing the changes. 
Essentially, what it does is having the WebEnginePart emit an openUrlRequest 
signal in response to the QWebEngineProfile::downloadRequest. This way, 
konqueror behaves the same with the webengine part as with khtml part and 
kwebkitpart for most downloads. There are some cases which still aren't 
working correctly. I was investigating these cases to fix them, but seeing 
that someone else was working on this issue, I decided to make my work public 
in case it could be useful.

Stefano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-download.patch
Type: text/x-patch
Size: 11412 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170717/004d72c0/attachment.bin>