D6684: Fix drop menu position with urlnavigator drops

David Faure noreply at phabricator.kde.org
Fri Jul 14 12:14:19 BST 2017


dfaure added inline comments.

INLINE COMMENTS

> dolphinview.cpp:1056
>                           event->modifiers());
>      dropUrls(destUrl, &dropEvent);
>  

This calls dropUrls(), directly so using sender() in dropUrls() seems dangerous, it will get the sender who got us here, which might work but that's a bit indirect and fragile.
Is there no way to get to the KUrlNavigator more cleanly from this class?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6684

To: elvisangelaccio, #dolphin
Cc: dfaure, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170714/46b673b9/attachment.htm>


More information about the kfm-devel mailing list