Review Request 129861: informationpanel: don't change color of scrollarea's viewport

Elvis Angelaccio elvis.angelaccio at kde.org
Sat Jan 21 22:39:41 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129861/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 10:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Submitted with commit c1d9becda259c0df58b1447b69f573b6ef13bfa1 by Elvis Angelaccio to branch Applications/16.12.


Bugs: 366203
    https://bugs.kde.org/show_bug.cgi?id=366203


Repository: dolphin


Description
-------

This code was added a long time ago in b1c9b5126d, but the commit
message doesn't explain why. If we remove it nothing seems to change and
we fix the ugly background on the scrollbar when Breeze draws a frame
around dockable panels.

BUG: 366203
FIXED-IN: 16.12.2


Diffs
-----

  src/panels/information/informationpanelcontent.cpp d519ff12125f09e345928ec4c2d2f02a71428cf7 

Diff: https://git.reviewboard.kde.org/r/129861/diff/


Testing
-------

Systemsettings -> Application Style -> Widget Style -> Configure button -> Frames tab -> Check "Draw frames around dockable panels"

Select some image in Dolphin, check the scrollbar in the information panel with/without this patch.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170121/181d756f/attachment.htm>


More information about the kfm-devel mailing list