Review Request 127799: Fix missing audio duration in details view

Marc André Wittorf marc-a at gmx.de
Sat Jan 21 00:38:05 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127799/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 12:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit 2e8e30026a207d380379fb2be0e4327bf4f455e8 by Albert Astals Cid on behalf of Marc André Wittorf to branch Applications/16.12.


Repository: dolphin


Description
-------

Enabling the 'duration' column in a folder with audio files did only show empty information. Properly initializing the QTime object fixes this.


Diffs
-----

  src/kitemviews/private/kbaloorolesprovider.cpp e0b889e 

Diff: https://git.reviewboard.kde.org/r/127799/diff/


Testing
-------

1. Find a folder with audio files
2. Make sure that Baloo has indexed this folder
3. Open this folder in Dolphin, detail view, enable the Audio/Duration column
4. Unpatched Dolphin does not display audio duration, patched Dolphin does

Tested on Gentoo x86_64 with Qt 5.5.1, KF 5.21.0 and Arch x86_64 with Qt 5.6.0 and KF 5.21.0.


Thanks,

Marc André Wittorf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170121/e0492a0f/attachment.htm>


More information about the kfm-devel mailing list