Review Request 129533: Dolphin: expand all one level, expand all, and collapse all in details view mode

[Don Nguyen]

> On Jan. 4, 2017, 8:33 p.m., Andreas Kainz wrote:
> > is it already shiped? Personally I'm very happy that dolphin has not that much entriey, and you can show/hide them. when you have now Expand, Expand Full, Collapse All as a single entry at right click and in view the UI get a lot of additional stuff most people didn't use.
> > 
> > Menubar -> View
> > wan't it be better to have a expand group with subgroups Expand, Expand Full, Collapse All?
> > why is it called Expand Full and Collapse All why not Expand All, Collapse All
> > 
> > Context menu (right click)
> > this is only available in the detail view isn't it. is it in a service cause than the user can add/remove the elements in Dolphin -> Preferences -> Services.
> > I also would prefer to have here an expand main group with subgroups for Expand, Expand All, Collapse All, like we have it for open with and activities
> > 
> > I will make the breeze icons for the patch

In this context Full is used to describe how to expand the items, eg. completely, and All is used to describe what to expand, eg. everything. The three functions were a generalization to minimize the amount of menu items and text for the following functions:  Expand Selection Once, Expand All Once, Expand Selection Full, Expand All Full, Collapse All.

These functionalities are not a service - they are simply convenience functions.

As the patch has not been shipped, we can still easily make any adjustments to how these functions are exposed.

If we go with a submenu route, we could do something like have a "Expand/Collapse" submenu containing: "Expand Selected, Expand All, Expand Selected Completely, Expand All Completely, Collapse All", and it would be a lot clearer what these functions do.  This design would add only one "Expand/Collapse" item to the View menu and context menu.  It would not even appear in the context menu, and would be disabled in the View menu, when not in details view.


- Don


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/#review101799
-----------------------------------------------------------


On Dec. 7, 2016, 9:53 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129533/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 9:53 p.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 196772
>     https://bugs.kde.org/show_bug.cgi?id=196772
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented functions:  Expand, Expand Full, and Collapse All.  They are available under the View and Control menus as well as custom toolbar buttons as Thomas explained and are disabled when not in details view mode.  They are also available via the context menu only in details view mode.  See screenshots.  
> Expand - If there is a selection, expand the selection once.  Otherwise expand everything once.  
> Expand Full - If there is a selection, expand the selected items completely.  Otherwise expand everything completely.
> Collapse All - Collapse everything.
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.h f67300d 
>   src/dolphincontextmenu.cpp ed3f643 
>   src/dolphinmainwindow.cpp e5103fd 
>   src/dolphinui.rc f197af4 
>   src/kitemviews/kfileitemmodel.h 8a0df72 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
>   src/tests/kfileitemmodeltest.cpp 6c45e11 
>   src/views/dolphinview.h 0b0d819 
>   src/views/dolphinview.cpp 4105628 
>   src/views/dolphinviewactionhandler.h eb375b5 
>   src/views/dolphinviewactionhandler.cpp 858f929 
> 
> Diff: https://git.reviewboard.kde.org/r/129533/diff/
> 
> 
> Testing
> -------
> 
> make test passes
> manual testing including:
> expand all on an Android SDK folder which yielded in 3180 folders, and 30993 files
> collapse all on above situation
> expand all on a directory that contains a symbolic link to a directory containing itself - operation will stop with error when expansion reaches a path that KCoreDirLister doesn't accept(see looptest screenshot) 
> changing directories in the middle of an expand all operation
> changing directories in the middle of a restore expanded directories operation 
> canceling in the middle of an expand all operation
> canceling in the middle of a restore expanded directories operation
> canceling in the middle of an expand all operation or restore expand directory operation, and then expanding an item manually with mouse click
> collapse all in the middle of an expand all operation
> collapse all in the middle of a restore expanded directories operation
> switched view modes and verified items are enabled only in details view mode
> 
> 
> File Attachments
> ----------------
> 
> looptest
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/f02b7e85-d0b3-4153-ae0d-e86a4ddfc916__looptest.png
> context-menu-disabled
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1fcc4412-e5f2-4c31-92bf-b828eea938f7__contextdisabled.png
> context-menu-with-selection
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/8a4709e5-d674-4f74-8cbc-a71841db7c36__selectioncontextenabled.png
> view-menu-enabled
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1ddaa88d-e0aa-441a-a840-5e2cdc06fbf2__viewmenuenabled.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170109/d3f4fe72/attachment.htm>