Review Request 129705: [DolphinSearchBox] Show search view only if it's enabled
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sun Jan 1 19:33:06 GMT 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129705/#review101712
-----------------------------------------------------------
Ship it!
Ship It!
- Emmanuel Pescosta
On Jan. 1, 2017, 8:31 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129705/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2017, 8:31 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> SearchBox request for searching after 1 sec, if url is changed before that time search view is showed again, which is annoying.
>
>
> Diffs
> -----
>
> src/search/dolphinsearchbox.h a80617476
> src/search/dolphinsearchbox.cpp 26ddd27f8
>
> Diff: https://git.reviewboard.kde.org/r/129705/diff/
>
>
> Testing
> -------
>
> Steps to reproduce:
> 1. Type in searchbox
> 2. Quick, before 1 sec timeout is reached, ckick in link in PanelFolder to change the url
> 3. Timeout is reached, search view is showed again, it's not desired.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170101/14a69d64/attachment.htm>
More information about the kfm-devel
mailing list