Review Request 129973: Dolphin: behavior change request->New Window opens with same URL

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129973/#review102681
-----------------------------------------------------------



+1

Just today I had a look at this very same code and thought the same :)


src/dolphinmainwindow.cpp (line 293)
<https://git.reviewboard.kde.org/r/129973/#comment68350>

    You can use initializer lists:
    
    {m_activeViewContainer->url()}


- Kai Uwe Broulik


On Feb. 28, 2017, 8:40 nachm., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129973/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 8:40 nachm.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch will cause a "New Window" command to open a new window with the URL from the active view.  Opening a new instance via launcher will still open a new window with the URL specified in Startup settings.  This is the behavior in Windows 10 file explorer.  The advantage is this gives the user a way to open a new window with the current URL(New Window) as well as a new window with URL specified in Startup settings(new instance) whereas currently, there isn't an easy way to open a new window with the current URL.  You'd have to either open a new window and copy and paste the URL, or open a new tab(which opens with the same URL) and detach it.  I'd much rather have the new window open with the current URL and if what I wanted was the Startup URL I could easily get there as it's alread
 y bookmarked.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 185db71 
> 
> Diff: https://git.reviewboard.kde.org/r/129973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170228/8d39f32e/attachment.htm>