Review Request 129084: [KStandardItemListWidget] Don't paint overlay outside view for devicePixelRatio > 1

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129084/#review102674
-----------------------------------------------------------



ftr: I ran into some trouble with iconified vs colorized icon because we just request a 32px then which results in a full folder icon showing up instead of the "share overlay", that's why I didn't push it yet.

- Kai Uwe Broulik


On Okt. 2, 2016, 4:01 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129084/
> -----------------------------------------------------------
> 
> (Updated Okt. 2, 2016, 4:01 nachm.)
> 
> 
> Review request for Dolphin and David Edmundson.
> 
> 
> Bugs: 369640
>     https://bugs.kde.org/show_bug.cgi?id=369640
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Translate the position by devicePixelRatio
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kstandarditemlistwidget.cpp 8740cb7 
> 
> Diff: https://git.reviewboard.kde.org/r/129084/diff/
> 
> 
> Testing
> -------
> 
> I now get proper overlays by the git plugin again.
> 
> So, this was broken in both KIconLoader and here, and I expected Dolphin to just use the code in KIconLoader (Review 129083 fixes symbolic links but this one fixes overlayplugin stuff)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170227/020563a4/attachment.htm>