Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Gregor Mi]

> On Sept. 20, 2016, 7:56 a.m., Emmanuel Pescosta wrote:
> > src/dolphinviewcontainer.cpp, line 617
> > <https://git.reviewboard.kde.org/r/123253/diff/5/?file=476239#file476239line617>
> >
> >     IMHO this debug output is only useful if it also contains the url ;)
> 
> Albert Astals Cid wrote:
>     Grigor, any reason this was not commited?

Hallo Albert,
thanks for the ping. The reason is that for months I try to find some time en block to fix my current KDE build setup to be sure to deliver correct code. Which would me enable to process the latest open issues with the current code. First this (https://git.reviewboard.kde.org/r/127111/) must be done and then this one. I am really sorry for the apparent non-action. I wouldn't mind someone else would take over. But if not, I will do it by the end of the year (probably much earlier).


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review99296
-----------------------------------------------------------


On Sept. 6, 2016, 10:17 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 10:17 a.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 335616
>     https://bugs.kde.org/show_bug.cgi?id=335616
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".
> 
> In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
>   src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 
> 
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
> 
> 
> Testing
> -------
> 
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace
> 
> 2016-02-18:
> There is now a difference in selection behaviour when using history buttons vs. direct url entry:
> 
> * history buttons: mark the item as current instead of restoring the previous selection
> * direct url entry: the child item is marked as current and selected
> 
> I personally prefer the selection because it is clearly visible. If it is ok I would try to adapt the history behaviour accordingly.
>   Update: I just saw that the "File Open" dialog does not do any selection at all if navigated back via history buttons. I'll postpone further action on this side issue for now.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170226/dbb49d27/attachment.htm>