Review Request 129383: Add explicit choices for executables/scripts execution

[Elvis Angelaccio]

> On Nov. 12, 2016, 10:31 a.m., Elvis Angelaccio wrote:
> > File Attachment: Behavior Settings - Behavior Settings
> > <https://git.reviewboard.kde.org/r/129383/#fcomment614>
> >
> >     As discussed yesterday, I'm not sure whether the new setting should be here or in the Confirmations tab (what does the VDG think?)
> >     
> >     In case we go for the Behavior tab, I'd not include the "all KDE applications" part in the sentence. Currently this setting is only used by Dolphin. If one day it will be used also by other KDE applications, then this setting should be moved from Dolphin to the System Settings (this is what happened to the setting for single/double click).
> >     
> >     What about a sentence like "What to do with executable scripts and desktop files"?
> 
> Thomas Pfeiffer wrote:
>     Behavior makes more sense to me because this isn't really about confirmations.
>     
>     The "all KDE applications" part actually comes from the text that's currently in the Confirmations tab, and your assessment is correct: If settings affect all applications, they belong in System Settings (and may be linked to from Dolphin's settings).
>     Therefore, the whole "Confirmations" tab should be moved to System Settings.
> 
> Don Nguyen wrote:
>     I am not familiar with the code outside of Dolphin.  Is there somewhere that we can forward this request to move these settings into System Settings?

> I am not familiar with the code outside of Dolphin.  Is there somewhere that we can forward this request to move these settings into System Settings?

Hi, sorry for disappearing. Since my last reply, Plasma started using this setting from Folder View, so one more reason why the Confirmation tab should be moved to System Settings. That's not going to be easy though, someone needs to do the work and, more importantly, find a proper location in System Settings (which is already quite crowded). If you are interested in making this happen, plasma-devel at kde.org is probably the best place to discuss it.

That said, for now it's ok if this patch lands only on the Dolphin side...


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129383/#review100799
-----------------------------------------------------------


On Nov. 12, 2016, 12:03 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129383/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2016, 12:03 a.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Bugs: 371837
>     https://bugs.kde.org/show_bug.cgi?id=371837
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is the patch for the suggestion proposed by me for bug 371837.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphin_generalsettings.kcfg c724afc 
>   src/settings/general/behaviorsettingspage.h 96eaf3d 
>   src/settings/general/behaviorsettingspage.cpp 6d1e8bb 
>   src/settings/general/confirmationssettingspage.h e702fe8 
>   src/settings/general/confirmationssettingspage.cpp 2419dc0 
> 
> Diff: https://git.reviewboard.kde.org/r/129383/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  
> make test passed.
> 
> 
> File Attachments
> ----------------
> 
> Behavior Settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/12/78938499-c709-4d95-a202-0da21cd34b57__general.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170224/6dcccd2c/attachment.htm>