Review Request 129959: Update hovered selection on mouse clicks as well as hoverMove events

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129959/
-----------------------------------------------------------

(Updated Feb. 20, 2017, 12:51 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: dolphin


Description
-------

Scenario:
- user right clicks an item
- a context menu appears, and because it's a context menu grabs all
mouse events at an X level
- user moves mouse over another item, but Dolphin doesn't get any
events
- user clicks to dismiss menu
- without moving the user clicks again

The context menu is for the wrong item.

This patch splits updating the hovered index into a new method, then
calls from that method from hoverMove which had the code before and also into
mousePress/doubleDoubleClick


Diffs
-----

  src/kitemviews/kitemlistcontroller.h 5e5e6b7c3eedc2a142552bd4c44ac635811a3b21 
  src/kitemviews/kitemlistcontroller.cpp 1c86ff03ff9b0b12bb0d2927f8e4ed1e0b67b38d 

Diff: https://git.reviewboard.kde.org/r/129959/diff/


Testing
-------

Right clicked on item with known actions
Using steps above clicked on an item with different known actions
Confirmed menu was correct


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170220/a585c656/attachment.htm>