Review Request 129662: Dolphin: "Show Filter Bar" action should be a toggle

[Don Nguyen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129662/
-----------------------------------------------------------

(Updated Feb. 18, 2017, 11:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit edf8e5737316204e4a96e5edf4cba4cdec1c71ef by Emmanuel Pescosta on behalf of Don Nguyen to branch master.


Repository: dolphin


Description
-------

The existing code suggests that the show filter bar action should be a
    KToggleAction.  DolphinViewContainer emits a showFilterBarChanged signal
    that is connected to DolphinMainWindow::updateFilterBarAction() to call
    setChecked() on the show filter bar action, which currently does nothing
    because the show filter bar action is not a checkable action.  I've
    changed the show filter bar action to a KToggleAction, and updated the
    code to make it function as a toggle as I believe it was intended.  If
    this was not the intention, then the existing code related to
    DolphinMainWindow::updateFilterBarAction() should be removed as they are
    not doing anything.


Diffs
-----

  src/dolphinmainwindow.h 7003e94 
  src/dolphinmainwindow.cpp e5103fd 
  src/dolphinviewcontainer.cpp 4e625c7 

Diff: https://git.reviewboard.kde.org/r/129662/diff/


Testing
-------

manual testing.  can turn on/off bar with keyboard shortcut, toolbar button.  toolbar button and menu state reflects the status of the filter bar.


File Attachments
----------------

filter bar off
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/b38ead2b-910a-4226-b081-24a7c53c7651__filteroff.png
filter bar on
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/16/d702a124-b909-4302-9848-ccc6e6223828__filteron.png


Thanks,

Don Nguyen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170218/391cde11/attachment.htm>