Review Request 121613: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media
Alexander Zhigalin
alexander at zhigalin.tk
Sat Feb 18 11:06:49 GMT 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121613/#review102542
-----------------------------------------------------------
Can you please port it to KF5?
- Alexander Zhigalin
On Дек. 20, 2014, 8:39 п.п., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121613/
> -----------------------------------------------------------
>
> (Updated Дек. 20, 2014, 8:39 п.п.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 158264
> http://bugs.kde.org/show_bug.cgi?id=158264
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Unmounting will fail if you are currently inside the mount point with the terminal kept opened. Therfore before attempting to unmount, we need to change the directory on the terminal.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 9d4c003
> dolphin/src/dolphinmainwindow.cpp 95b08af
> dolphin/src/panels/places/placesitemmodel.h 4a374e5
> dolphin/src/panels/places/placesitemmodel.cpp 6accdc8
> dolphin/src/panels/places/placespanel.h 16112e8
> dolphin/src/panels/places/placespanel.cpp 720e07c
> dolphin/src/panels/terminal/terminalpanel.h b65239b
> dolphin/src/panels/terminal/terminalpanel.cpp f827503
>
> Diff: https://git.reviewboard.kde.org/r/121613/diff/
>
>
> Testing
> -------
>
> Everything seems to work properly. Didn't find any view-terminal sync issues.
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170218/53e4dc84/attachment.htm>
More information about the kfm-devel
mailing list