Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[arnav dhamija]

> On Feb. 13, 2017, 4:41 p.m., Emmanuel Pescosta wrote:
> > src/dolphinmainwindow.h, line 520
> > <https://git.reviewboard.kde.org/r/129044/diff/5/?file=491210#file491210line520>
> >
> >     Check your editor settings and enable "ensure single trailing newline" and then open+save dolphinmainwindow.{h,cpp}. (please note that I don't use Atom, so the settings screenshot I have found may be outdated ;) )

Yes, it turns out that Atom was doing something weird so I added the newline in Kate instead. I'll ship it right away then! :)


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review102525
-----------------------------------------------------------


On Feb. 13, 2017, 4:52 p.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 4:52 p.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170213/3b042ae2/attachment.htm>