Review Request 127969: Use toggleViewAction directly rather than creating a new one

Kai Uwe Broulik kde at privat.broulik.de
Wed Feb 8 11:35:26 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127969/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 11:35 vorm.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: dolphin


Description
-------

I don't see why we need a separate QAction.

This makes menus provided by Qt (eg. when right-clicking the menu bar or the header of an unlocked panel) consistent with Dolphin's own menus, ie. they also show icon and shortcut for the action.


Diffs
-----

  src/dolphinmainwindow.cpp 1fadaf7 

Diff: https://git.reviewboard.kde.org/r/127969/diff/


Testing
-------

Seems to work.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170208/4d624183/attachment.htm>


More information about the kfm-devel mailing list