Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[arnav dhamija]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 4:27 p.m.)


Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.


Changes
-------

Implements the handling of stash action in a better way - by *not* having a checkable QPushButton.


Repository: dolphin


Description
-------

The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.


Diffs (updated)
-----

  src/dolphinmainwindow.h 7003e94 
  src/dolphinmainwindow.cpp 4d97fc1 
  src/dolphintabpage.h 9d18088 
  src/dolphintabpage.cpp c674e1e 
  src/dolphinui.rc f197af4 

Diff: https://git.reviewboard.kde.org/r/129044/diff/


Testing
-------


File Attachments
----------------

Screenshot of the button in the toolbar
  https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png


Thanks,

arnav dhamija

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170202/70943f98/attachment.htm>